gdb/dwarf: fix bound check in read_rnglist_index
authorSimon Marchi <simon.marchi@efficios.com>
Tue, 2 Feb 2021 15:40:50 +0000 (10:40 -0500)
committerSimon Marchi <simon.marchi@polymtl.ca>
Tue, 2 Feb 2021 15:40:50 +0000 (10:40 -0500)
commit5e4d9bbc4b4e57eacb614c38f30dac9af08cace8
treedd9185a7ddb8a3754ea3042d4baad15ba2973ad2
parenta0c1eeba9b13b759b058dd5640ccb0dc2630a723
gdb/dwarf: fix bound check in read_rnglist_index

I think this check in read_rnglist_index is wrong:

      /* Validate that reading won't go beyond the end of the section.  */
      if (start_offset + cu->header.offset_size > rnglist_base + section->size)
        error (_("Reading DW_FORM_rnglistx index beyond end of"
                 ".debug_rnglists section [in module %s]"),
               objfile_name (objfile));

The addition `rnglist_base + section->size` doesn't make sense.
rnglist_base is an offset into `section`, so it doesn't make sense to
add it to `section`'s size.  `start_offset` also is an offset into
`section`, so we should just compare it to just `section->size`.

gdb/ChangeLog:

* dwarf2/read.c (read_rnglist_index): Fix bound check.

Change-Id: If0ff7c73f4f80f79aac447518f4e8f131f2db8f2
gdb/ChangeLog
gdb/dwarf2/read.c