Change tui_source_window_base::set_contents to return bool
authorTom Tromey <tom@tromey.com>
Wed, 13 Nov 2019 00:26:50 +0000 (17:26 -0700)
committerTom Tromey <tom@tromey.com>
Fri, 20 Dec 2019 16:15:52 +0000 (09:15 -0700)
commit61c33f105c71d27386e5b3cc6e1c5f71efe7ed01
tree3d61884a4c61df3cb404f931731d617fc4fe6060
parent469b073133fa35b54ab4f1bc3dee42ccede84689
Change tui_source_window_base::set_contents to return bool

This changes tui_source_window_base::set_contents to return bool,
rather than tui_status.  It also changes one implementation of
set_contents to use early returns rather than a variable, which IMO
makes it easier to follow.

gdb/ChangeLog
2019-12-20  Tom Tromey  <tom@tromey.com>

* tui/tui-winsource.h (struct tui_source_window_base)
<set_contents>: Return bool.
* tui/tui-winsource.c
(tui_source_window_base::update_source_window_as_is): Update.
* tui/tui-source.h (struct tui_source_window) <set_contents>:
Return bool.
* tui/tui-source.c (tui_source_window::set_contents): Return
bool.  Simplify.
* tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
Return bool.
* tui/tui-disasm.c (tui_disasm_window::set_contents): Return
bool.

Change-Id: I8c5212400cd7aadf35760c22d5344cd3b9435674
gdb/ChangeLog
gdb/tui/tui-disasm.c
gdb/tui/tui-disasm.h
gdb/tui/tui-source.c
gdb/tui/tui-source.h
gdb/tui/tui-winsource.c
gdb/tui/tui-winsource.h