(proof-new) Miscellaneous changes to strings for proofs (#5362)
authorAndrew Reynolds <andrew.j.reynolds@gmail.com>
Fri, 6 Nov 2020 19:47:22 +0000 (13:47 -0600)
committerGitHub <noreply@github.com>
Fri, 6 Nov 2020 19:47:22 +0000 (13:47 -0600)
commit6476c8c75ed7fd584b5afa658dd2c8ba277c59e2
treee1d4d934e133d4222e676fafab6f33c37be61d23
parent04dc5b60462dc367fe1b99254c215957006f7b21
(proof-new) Miscellaneous changes to strings for proofs (#5362)

This includes all minor remaining changes from proof-new for strings that were not merged to master.

This includes mostly minor changes to make proofs pass, including reordering assertions. It also removes some non-standard pedantic checks as these are now subsumed by standard ones.

It also makes the strings rewriter slightly more safe when checking arithmetic entailment under assumptions. This code used substitution, which was not safe when quantifiers were involved. This is replaced by capture avoiding substitution here.
src/theory/strings/arith_entail.cpp
src/theory/strings/base_solver.cpp
src/theory/strings/infer_proof_cons.cpp
src/theory/strings/normal_form.cpp
src/theory/strings/term_registry.cpp
src/theory/strings/theory_strings_preprocess.cpp