Fix problem where gold fails to issue an undefined symbol error during LTO.
authorCary Coutant <ccoutant@gmail.com>
Tue, 22 Mar 2016 02:07:55 +0000 (19:07 -0700)
committerCary Coutant <ccoutant@gmail.com>
Tue, 22 Mar 2016 04:42:15 +0000 (21:42 -0700)
commit648c5cbbf34dcbf96bde7e07b14868777fd5d635
treeb2d83b9ce51b0a3d3d84601c675f606b89134520
parent6f4c0a426c653867c40936a9b8f503628adbd64b
Fix problem where gold fails to issue an undefined symbol error during LTO.

During LTO, if (1) an IR file contains a COMDAT group that is kept,
(2) a later non-claimed file contains the same group, which we discard,
and (3) the plugin fails to provide a definition of the symbols in that
COMDAT group, gold silently resolves any references to those symbols
to 0.

This patch adds a check for a placeholder symbol when deciding
whether to issue an undefined symbol error. It also adds an extra
note after any undefined placeholder symbol error that explains
that a definition was expected from the plugin.

gold/
PR gold/19842
* errors.cc (Errors::undefined_symbol): Add info message when
symbol should have been provided by a plugin.
* target-reloc.h (issue_undefined_symbol_error): Check for
placeholder symbols defined in discarded sections.
* testsuite/Makefile.am (plugin_test_9b): New test case.
* testsuite/Makefile.in: Regenerate.
* testsuite/plugin_test_9b_elf.cc: New test source file.
* testsuite/plugin_test_9b_ir.cc: New test source file.
gold/ChangeLog
gold/errors.cc
gold/target-reloc.h
gold/testsuite/Makefile.am
gold/testsuite/Makefile.in
gold/testsuite/plugin_test_9b_elf.cc [new file with mode: 0644]
gold/testsuite/plugin_test_9b_ir.cc [new file with mode: 0644]