style: Force Python.h to be included before main header
authorAndreas Sandberg <andreas.sandberg@arm.com>
Tue, 7 Feb 2017 15:28:33 +0000 (15:28 +0000)
committerAndreas Sandberg <andreas.sandberg@arm.com>
Tue, 7 Feb 2017 15:28:33 +0000 (15:28 +0000)
commit653b4657e67f24339abd18a154a57ca5d578b4b9
treec5ed13b206407654e7205ec4433cbd58847e682a
parent227bdde922e919771e8702fc422461df4f1d317d
style: Force Python.h to be included before main header

Python's header files set various compiler macros (e.g.,
_XOPEN_SOURCE) unconditionally. This triggers preprocessor warnings
that end up being treated as errors. The Python integration manual [1]
strongly recommends that Python.h is included before any system
header. The style guide used to mandate that Python.h is included
first in any file that needs it. This requirement was changed to
always include a source file's main header first, which ended up
triggering these errors.

This change updates the style checker to always include Python.h
before the main header file.

[1] https://docs.python.org/2/extending/extending.html

Change-Id: Id6a4f7fc64a336a8fd26691a0ca682abeb1d1579
Signed-off-by: Andreas Sandberg <andreas.sandberg@arm.com>
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Reviewed-by: Pierre-Yves PĂ©neau <pierre-yves.peneau@lirmm.fr>
src/python/swig/pyevent.cc
src/sim/init.cc
src/sim/py_interact.cc
util/style/sort_includes.py