Fix TYPE_DECLARED_CLASS thinko
authorKeith Seitz <keiths@redhat.com>
Wed, 24 Mar 2021 20:41:14 +0000 (13:41 -0700)
committerKeith Seitz <keiths@redhat.com>
Wed, 24 Mar 2021 20:44:17 +0000 (13:44 -0700)
commit68f115f8c088bafd7d60b1245867ee8f42ccfcef
tree42230e8dca50c73f8dda501648cdee0720f706fb
parent41c0087ba5f1e88395be42ae33c3f7b9b2dd6745
Fix TYPE_DECLARED_CLASS thinko

Simon pointed out an error that I made in
compile_cplus_conver_struct_or_union in my original C++ compile submission:

  if (type->code () == TYPE_CODE_STRUCT)
    {
      const char *what = TYPE_DECLARED_CLASS (type) ? "struct" : "class";

      resuld = instance->plugin ().build_decl
        (what, name.get (), (GCC_CP_SYMBOL_CLASS | nested_access
                             | (TYPE_DECLARED_CLASS (type)
                                ? GCC_CP_FLAG_CLASS_NOFLAG
                                : GCC_CP_FLAG_CLASS_IS_STRUCT)),
         0, nullptr, 0, filename, line);
    }

Notice that WHAT will contain "struct" for TYPE_DECLARED_CLASS. Whoops.

Fortunately this first parameter of build_decl is only used for
debugging.

gdb/ChangeLog
2021-03-24  Keith Seitz  <keiths@redhat.com>

* compile/compile-cplus-types.c
(compile_cplus_convert_struct_or_union): Fix TYPE_DECLARED_CLASS
thinko.
gdb/ChangeLog
gdb/compile/compile-cplus-types.c