i965/gen6/blorp: Set need_workaround_flush at top of blorp
authorChad Versace <chad.versace@linux.intel.com>
Tue, 24 Dec 2013 01:48:45 +0000 (17:48 -0800)
committerChad Versace <chad.versace@linux.intel.com>
Thu, 9 Jan 2014 23:02:39 +0000 (15:02 -0800)
commit6a5c86f48675d2ca0975d69e0899e72afaab29e5
tree7d88595e42c44767601fdff790d258d910d78abb
parent5e0cd58de4261e9dca7a15037192e7e9426a0207
i965/gen6/blorp: Set need_workaround_flush at top of blorp

Unconditionally set brw->need_workaround_flush at the top of gen6 blorp
state emission.

The art of emitting workaround flushes on Sandybridge is mysterious and
not fully understood. Ken and I believe that
intel_emit_post_sync_nonzero_flush() may be required when switching from
regular drawing to blorp.  This is an extra safety measure to prevent
undiscovered difficult-to-diagnose gpu hangs.

I verified that on ChromeOS, pre-patch, need_workaround_flush was not
set at the top of blorp, as Paul expected. To verify, I inserted the
following debug code at the top of gen6_blorp_exec(), restarted the ui,
and inspected the logs in /var/log/ui. The abort gets triggered so early
that the browser never appears on the display.

    static void
    gen6_blorp_exec(...)
    {
        if (!brw->need_workaround_flush) {
            fprintf(stderr, "chadv: %s:%d\n", __FILE__, __LINE__);
            abort();
        }
        ...
    }

CC: Kenneth Graunke <kenneth@whitecape.org>
CC: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Paul Berry <stereotype441@gmail.com>
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
src/mesa/drivers/dri/i965/gen6_blorp.cpp