Normalize Ada ptype to use a single "?"
authorTom Tromey <tromey@adacore.com>
Tue, 3 Dec 2019 20:31:21 +0000 (13:31 -0700)
committerTom Tromey <tromey@adacore.com>
Tue, 10 Dec 2019 15:56:39 +0000 (08:56 -0700)
commit6c71eb7d70c3678f595cd8e66d78c9da5bd3ef4e
tree771eb800267f5ffe7370e3b30962495fe68848d6
parent0a0a05217640d96938b4cd58c9ce01ef5026e15a
Normalize Ada ptype to use a single "?"

Sometimes -- notably with unchecked unions -- the Ada "ptype" code
will print a "?" or "??" to indicate something unknown.  The choice of
what was printed was somewhat arbitrary, and in one case, Ada would
print an empty string rather than "?".

This patch normalizes the Ada code to use "?" rather than an empty
string or "??".  My reasoning here is that a single question mark is
enough to convey unknown-ness.

gdb/ChangeLog
2019-12-10  Tom Tromey  <tromey@adacore.com>

* ada-typeprint.c (print_choices): Use a single "?".
(print_variant_part): Print "?" if the discriminant name
is not known.

gdb/testsuite/ChangeLog
2019-12-10  Tom Tromey  <tromey@adacore.com>

* gdb.ada/unchecked_union.exp: New file.
* gdb.ada/unchecked_union/pck.adb: New file.
* gdb.ada/unchecked_union/pck.ads: New file.
* gdb.ada/unchecked_union/unchecked_union.adb: New file.
* gdb-utils.exp (string_to_regexp): Also quote "?".

Change-Id: I3403040780a155ffa2c44c8e6a04ba86bc810e29
gdb/ChangeLog
gdb/ada-typeprint.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.ada/unchecked_union.exp [new file with mode: 0644]
gdb/testsuite/gdb.ada/unchecked_union/pck.adb [new file with mode: 0644]
gdb/testsuite/gdb.ada/unchecked_union/pck.ads [new file with mode: 0644]
gdb/testsuite/gdb.ada/unchecked_union/unchecked_union.adb [new file with mode: 0644]
gdb/testsuite/lib/gdb-utils.exp