New /s modifier for the disassemble command.
authorDoug Evans <xdje42@gmail.com>
Sat, 15 Aug 2015 04:45:54 +0000 (21:45 -0700)
committerDoug Evans <xdje42@gmail.com>
Sat, 15 Aug 2015 04:45:54 +0000 (21:45 -0700)
commit6ff0ba5f7b8a2b10642bbb233a32043595c55670
treec5292016ff0e4c7a254c227d9a7c9579b05e8ff1
parentb56ccc202ab674998baf52a710d736702734f9ab
New /s modifier for the disassemble command.

The "source centric" /m option to the disassemble command is often
unhelpful, e.g., in the presence of optimized code.
This patch adds a /s modifier that is better.
For one, /m only prints instructions from the originating source file,
leaving out instructions from e.g., inlined functions from other files.

gdb/ChangeLog:

PR gdb/11833
* NEWS: Document new /s modifier for the disassemble command.
* cli/cli-cmds.c (disassemble_command): Add support for /s.
(_initialize_cli_cmds): Update online docs of disassemble command.
* disasm.c: #include "source.h".
(struct deprecated_dis_line_entry): Renamed from dis_line_entry.
All uses updated.
(dis_line_entry): New struct.
(hash_dis_line_entry, eq_dis_line_entry): New functions.
(allocate_dis_line_table): New functions.
(maybe_add_dis_line_entry, line_has_code_p): New functions.
(dump_insns): New arg end_pc.  All callers updated.
(do_mixed_source_and_assembly_deprecated): Renamed from
do_mixed_source_and_assembly.  All callers updated.
(do_mixed_source_and_assembly): New function.
(gdb_disassembly): Handle /s (DISASSEMBLY_SOURCE).
* disasm.h (DISASSEMBLY_SOURCE_DEPRECATED): Renamed from
DISASSEMBLY_SOURCE.  All uses updated.
(DISASSEMBLY_SOURCE): New macro.
* mi/mi-cmd-disas.c (mi_cmd_disassemble): New modes 4,5.

gdb/doc/ChangeLog:

* gdb.texinfo (Machine Code): Update docs for mixed source/assembly
disassembly.
(GDB/MI Data Manipulation): Update docs for new disassembly modes.

gdb/testsuite/ChangeLog:

* gdb.mi/mi-disassemble.exp: Update.
* gdb.base/disasm-optim.S: New file.
* gdb.base/disasm-optim.c: New file.
* gdb.base/disasm-optim.h: New file.
* gdb.base/disasm-optim.exp: New file.
15 files changed:
gdb/ChangeLog
gdb/NEWS
gdb/cli/cli-cmds.c
gdb/disasm.c
gdb/disasm.h
gdb/doc/ChangeLog
gdb/doc/gdb.texinfo
gdb/mi/mi-cmd-disas.c
gdb/record.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.base/disasm-optim.S [new file with mode: 0644]
gdb/testsuite/gdb.base/disasm-optim.c [new file with mode: 0644]
gdb/testsuite/gdb.base/disasm-optim.exp [new file with mode: 0644]
gdb/testsuite/gdb.base/disasm-optim.h [new file with mode: 0644]
gdb/testsuite/gdb.mi/mi-disassemble.exp