i965/gen4-5: Enable 16-wide dispatch on shaders with control flow.
authorFrancisco Jerez <currojerez@riseup.net>
Mon, 6 Jul 2015 15:55:26 +0000 (18:55 +0300)
committerFrancisco Jerez <currojerez@riseup.net>
Tue, 7 Jul 2015 17:20:22 +0000 (20:20 +0300)
commit7009e2683ebb917393d87639f549588f22c03a32
tree3c97b369fb2790d7bc6441bb80f04c267948e515
parent24842e18aabdaeff41668b0e71e52d32975d2ccd
i965/gen4-5: Enable 16-wide dispatch on shaders with control flow.

This was probably disabled due to a combination of several bugs in the
generator code (fixed earlier in this series) and a misunderstanding
of the hardware spec.  The documentation for most control flow
instructions mentions among other restrictions:

 "Instruction compression is not allowed."

This however doesn't have any implications on 16 wide not being
supported, because none of the control flow instructions have
multi-register operands (control flow instructions are not compressed
on more recent hardware either, except maybe SNB's IF with inline
compare).  In fact Gen4-5 had 16-wide control flow masks and stacks,
and the spec mentions in several places that control flow instructions
push and pop 16 channels worth of data -- Otherwise there doesn't seem
to be any indication that it shouldn't work.

Causes no piglit regressions, and gives the following shader-db
results on ILK:

 total instructions in shared programs: 4711384 -> 4711384 (0.00%)
 instructions in affected programs:     0 -> 0
 helped:                                0
 HURT:                                  0
 GAINED:                                1215
 LOST:                                  0

Reviewed-by: Matt Turner <mattst88@gmail.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/mesa/drivers/dri/i965/brw_fs_nir.cpp