Don't include selftests objects in build when unit tests are disabled
authorSimon Marchi <simon.marchi@efficios.com>
Thu, 12 Mar 2020 18:18:21 +0000 (14:18 -0400)
committerSimon Marchi <simon.marchi@efficios.com>
Thu, 12 Mar 2020 18:18:36 +0000 (14:18 -0400)
commit74cd3f9d7e2bc82a295011230dc5261cd1129b4f
tree5dcac5dfb53824783d1ec65828c90e3197c2bbd2
parentdb6878ac5538661c8d66c916a533bd4268217fcb
Don't include selftests objects in build when unit tests are disabled

While working on the preceding selftests patches, I noticed that some
selftests-specific files are included in the build even when selftests
are disabled, namely disasm-selftest.c and gdbarch-selftests.c.  These
files are entirely #if'ed out when building with selftests disabled.

This is not a huge problem, but I think it would make more sense if
these files were simply not built.

With this patch, I propose to put all the selftests-specific source
files into a SELFTESTS_SRCS Makefile variable (even selftest-arch.c,
which is currently added by the configure script).

gdb/ChangeLog:

* Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
(SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
gdbarch-selfselftests.c and selftest-arch.c.
(SUBDIR_UNITTESTS_OBS): Rename to...
(SELFTESTS_OBS): ... this.
(COMMON_SFILES): Remove disasm-selftests.c and
gdbarch-selftests.c.
* configure.ac: Don't add selftest-arch.{c,o} to
CONFIG_{SRCS,OBS}.
* disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
preprocessor conditions.
gdb/ChangeLog
gdb/Makefile.in
gdb/configure
gdb/configure.ac
gdb/disasm-selftests.c
gdb/gdbarch-selftests.c