package/dtc: needs host-pkgconf unconditionally
authorYann E. MORIN <yann.morin.1998@free.fr>
Sun, 3 Nov 2019 10:42:06 +0000 (11:42 +0100)
committerThomas Petazzoni <thomas.petazzoni@bootlin.com>
Fri, 8 Nov 2019 20:57:58 +0000 (21:57 +0100)
commit78b77a5c4a5eef1ad5b4af51879758d38a8cc98d
treea47c3b591277459b1a54e8532e8e4d70762a9bd0
parent6d8c56f77627e594fb285a7c6f4245ed196ce392
package/dtc: needs host-pkgconf unconditionally

Commits 495e757d2 (package/dtc: add optional libyaml dependency) and
e43d9072a (package/dtc: fix build without libyaml), added a conditional
dependency to host-pkgconf, when libyaml is enabled, while commit
56d6dd453 (package/dtc: disable valgrind) explicitly disabled support of
valgrind.

However, presence of libyaml, as well as that of valgrind, *is* detected
by calling pkg-config:

    NO_VALGRIND := $(shell $(PKG_CONFIG) --exists valgrind; echo $$?)
    NO_YAML := $(shell $(PKG_CONFIG) --exists yaml-0.1; echo $$?)

Passing NO_YAML=1 or NO_VALGRIND=1 do not prevent the tests from being
executed, which would yield messages like:

    /bin/sh: 1: /home/ymorin/dev/buildroot/O/host/bin/pkg-config: not found

(note however that, even if the test is executed, the value we pass on
the command line still takes precedence, and the support for either is
properly disabled.)

So, move the dependency on host-pkgconfig out of the condition. Ditto
for the host package.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Titouan Christophe <titouan.christophe@railnova.eu>
Cc: Carlos Santos <unixmania@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
package/dtc/dtc.mk