i965: Fix glColorPointer(GL_FIXED)
authorChad Versace <chad.versace@linux.intel.com>
Tue, 28 May 2013 23:26:07 +0000 (16:26 -0700)
committerChad Versace <chad.versace@linux.intel.com>
Mon, 3 Jun 2013 20:03:28 +0000 (13:03 -0700)
commit7a9f4d3e7114ca709658a620644ad897bdda41e7
tree2efaa57782a23c1b894b61603ddca405fa96aba8
parente54c924a0e9b9a504eae1eb68daaf51f21689629
i965: Fix glColorPointer(GL_FIXED)

When a gl_client_array is created with glColorPointer,
gl_client_array::Normalized is true. This caused the translation from the
gl_client_array's type to a BRW_SURFACEFORMAT to assertion fail.

Fixes the spinning cube's color in Android 4.2's ApiDemos.apk,
"Graphics > OpenGL ES".

Fixes assertion failure in mesa-demos/src/egl/opengles1/tri_x11 on Haswell
and Ivybridge:
  brw_draw_upload.c:287: get_surface_type: Assertion `0' failed.

No Piglit regressions on Haswell.

Note: This is a candidate for the 9.1 branch.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42182
Issue: AXIA-2954
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
src/mesa/drivers/dri/i965/brw_draw_upload.c