(proof-new) Fix missing connection in trust substitution proofs (#6685)
authorAndrew Reynolds <andrew.j.reynolds@gmail.com>
Mon, 7 Jun 2021 17:44:20 +0000 (12:44 -0500)
committerGitHub <noreply@github.com>
Mon, 7 Jun 2021 17:44:20 +0000 (17:44 +0000)
commit7e9e71c7bd2bcbdcb2cef0d8f99bf34082bf4081
tree201fe80043ddb91a72f56f34c2906ef990ad6faf
parent4cb2b23322794fc684db4f4a9f9e14e0157c83b0
(proof-new) Fix missing connection in trust substitution proofs (#6685)

This PR fixes a missing connection in trust substitution proofs, which was the cause of open proofs when solved equalities from ppAssert were not justified by proofs.

Also distinguishes TRUST_SUBS_EQ from TRUST_SUBS_MAP for clarity.
src/proof/proof_rule.cpp
src/proof/proof_rule.h
src/theory/builtin/proof_checker.cpp
src/theory/theory.h
src/theory/trust_substitutions.cpp
test/regress/CMakeLists.txt
test/regress/regress0/bv/core/bitvec1.smtv1.smt2
test/regress/regress0/bv/core/bitvec3.smtv1.smt2
test/regress/regress0/bv/core/constant_core.smt2
test/regress/regress0/cores/issue3455.smt2
test/regress/regress0/proofs/trust-subs-eq-open.smt2 [new file with mode: 0644]