C: use full locations within c_parser_expr_list's vec<location_t>
authorDavid Malcolm <dmalcolm@redhat.com>
Mon, 21 Aug 2017 17:03:15 +0000 (17:03 +0000)
committerDavid Malcolm <dmalcolm@gcc.gnu.org>
Mon, 21 Aug 2017 17:03:15 +0000 (17:03 +0000)
commit7f204c0f4b23fa06878a34535a525d0295414406
treedffd9f4456e124fd12725644bce859641cf32996
parent2f687306d7dbbae7ad45e79dafde45f7b97f03c4
C: use full locations within c_parser_expr_list's vec<location_t>

The previous patch uncovered a bug in how c_parser_expr_list builds the
vec<location_t>: it was only using the location of the first token
within each assignment-expression in the expr-list.

This shows up in e.g. this -Wformat warning, where only part of the
2nd param is underlined:

   printf("hello %i", (long)0);
                 ~^   ~
                 %li

This patch fixes c_parser_expr_list to use the full range of
each assignment-expression in the list for the vec<location_t>, so
that for the above we print:

   printf("hello %i", (long)0);
                 ~^   ~~~~~~~
                 %li

gcc/c/ChangeLog:
* c-parser.c (c_parser_expr_list): Use c_expr::get_location ()
rather than peeking the location of the first token.
* c-tree.h (c_expr::get_location): New method.

gcc/testsuite/ChangeLog:
* gcc.dg/format/diagnostic-ranges.c (test_mismatching_types):
Update expected result to show all of "(long)0" being underlined.
* gcc.dg/plugin/diagnostic-test-string-literals-1.c
(test_multitoken_macro): Update expected underlining.

From-SVN: r251239
gcc/c/ChangeLog
gcc/c/c-parser.c
gcc/c/c-tree.h
gcc/testsuite/ChangeLog
gcc/testsuite/gcc.dg/format/diagnostic-ranges.c
gcc/testsuite/gcc.dg/plugin/diagnostic-test-string-literals-1.c