c++: Fix tsubst ICE with invalid static_cast [PR95728]
authorMarek Polacek <polacek@redhat.com>
Wed, 17 Jun 2020 23:23:10 +0000 (19:23 -0400)
committerMarek Polacek <polacek@redhat.com>
Thu, 18 Jun 2020 12:32:21 +0000 (08:32 -0400)
commit81caacc273399c91ae3182021ad87bc2ba786039
tree04a873f9ad95aa776b79676f9aad86e01070d0f5
parent2c53566539265f56df1c0a60dca6dfc30f2c621d
c++: Fix tsubst ICE with invalid static_cast [PR95728]

Since r11-423 tsubst_copy_and_build/TREE_LIST uses tsubst_tree_list
instead of open coding it.  While the latter could return an error
node wrapped in a TREE_LIST, the former can return a naked error node.

That broke in tsubst_copy_and_build/NEW_EXPR:
  tree placement = RECUR (TREE_OPERAND (t, 0));
  // placement is now error_mark_node, so...
  for (; placement != NULL_TREE; placement = TREE_CHAIN (placement))
  // ... this crashes

If we just return, we avoid the ICE and improve the diagnostic a bit.

gcc/cp/ChangeLog:

PR c++/95728
* pt.c (tsubst_copy_and_build) <case NEW_EXPR>: Return error_mark_node
if placement is erroneous.

gcc/testsuite/ChangeLog:

PR c++/95728
* g++.dg/template/cast6.C: New test.
gcc/cp/pt.c
gcc/testsuite/g++.dg/template/cast6.C [new file with mode: 0644]