ralloc: Make rewrite_tail increase "start" by the new text's length.
authorKenneth Graunke <kenneth@whitecape.org>
Fri, 10 Feb 2012 04:03:36 +0000 (20:03 -0800)
committerKenneth Graunke <kenneth@whitecape.org>
Tue, 28 Feb 2012 21:07:12 +0000 (13:07 -0800)
commit8292b7419d0405e94a5ea270ba710d20f0eb071f
tree06aacf1c3dfc3c592909f54bb57a48d56267c3a8
parent579ccae73d29211c9f5c01ba527e1743ea39c94e
ralloc: Make rewrite_tail increase "start" by the new text's length.

Both callers of rewrite_tail immediately compute the new total string
length by adding the (known) length of the existing string plus the
length of the newly appended text.  Unfortunately, callers generally
won't know the length of the new text, as it's printf-formatted.

Since ralloc already computes this length, it makes sense to add it in
and save the caller the effort.  This simplifies both existing callers,
but more importantly, will allow for cheap-appending in the next commit.

v2: The link_uniforms code needs both the old and new length.
    Apply the obvious fix (which sadly makes it less of a cleanup).

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> [v1]
Acked-by: José Fonseca <jfonseca@vmware.com> [v1]
src/glsl/link_uniforms.cpp
src/glsl/linker.h
src/glsl/ralloc.c
src/glsl/ralloc.h