tree-optimization/33315 - common stores during sinking
authorRichard Biener <rguenther@suse.de>
Wed, 15 Apr 2020 10:09:01 +0000 (12:09 +0200)
committerRichard Biener <rguenther@suse.de>
Fri, 15 May 2020 06:56:08 +0000 (08:56 +0200)
commit84935c9822183ce403bb361c5f405711b9a808c6
treefbf59f25c432dc6445e1146d4af0446026d6ab11
parent8a15faa730f99100f6f3ed12663563356ec5a2c0
tree-optimization/33315 - common stores during sinking

This implements commoning of stores to a common successor in
a simple ad-hoc way.  I've decided to put it into the code sinking
pass since, well, it sinks stores.  It's still separate since
it does not really sink code into less executed places.

It's ad-hoc since it does not perform any dataflow or alias analysis
but simply only considers trailing stores in a block, iteratively
though.  If the stores are from different values a PHI node is
inserted to merge them.  gcc.dg/tree-ssa/split-path-7.c shows
that path splitting will eventually undo this very transform,
I've decided to not bother with it and simply disable sinking for
the particular testcase.

Doing this transform is good for code size when the stores are
from constants, once we have to insert PHIs the situation becomes
less clear but it's a transform we do elsewhere as well
(cselim for one), and reversing the transform should be easy.

2020-05-15  Richard Biener  <rguenther@suse.de>

PR tree-optimization/33315
* tree-ssa-sink.c: Include tree-eh.h.
(sink_stats): Add commoned member.
(sink_common_stores_to_bb): New function implementing store
commoning by sinking to the successor.
(sink_code_in_bb): Call it, pass down TODO_cleanup_cfg returned.
(pass_sink_code::execute): Likewise.  Record commoned stores
in statistics.

* gcc.dg/tree-ssa/ssa-sink-13.c: New testcase.
* gcc.dg/tree-ssa/ssa-sink-14.c: Likewise.
* gcc.dg/tree-ssa/split-path-7.c: Disable sinking.
gcc/ChangeLog
gcc/testsuite/ChangeLog
gcc/testsuite/gcc.dg/tree-ssa/split-path-7.c
gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-13.c [new file with mode: 0644]
gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-14.c [new file with mode: 0644]
gcc/tree-ssa-sink.c