Fixes for memory access violations in the coffdump program.
authorNick Clifton <nickc@redhat.com>
Tue, 6 Jan 2015 16:06:45 +0000 (16:06 +0000)
committerNick Clifton <nickc@redhat.com>
Tue, 6 Jan 2015 16:06:45 +0000 (16:06 +0000)
commit85880250e591a51624d24db653aaace0c5ce5943
tree0319d173921cd8ec36f007e0270dc883a30e8336
parentfce10a8494efa8faec67b718f25e06d3d71694b3
Fixes for memory access violations in the coffdump program.

PR binutils/17512
* coffdump.c (dump_coff_section): Check for a symbol being
available before printing its name.
(main): Check the return value from coff_grok.
* coffgrok.c: Reformat and tidy.
Add range checks to most functions.
(coff_grok): Return NULL if the input bfd is not in a COFF
format.
* coffgrok.h: Reformat and tidy.
(struct coff_section): Change the nrelocs field to unsigned.
* srconv.c (main): Check the return value from coff_grok.

* coff-i860.c (CALC_ADDEND): Always set an addend value.
* tekhex.c (getvalue): Add an end pointer parameter.  Use it to
avoid reading off the end of the buffer.
(getsym): Likewise.
(first_phase): Likewise.
(pass_over): Pass an end pointer to the invoked function.
bfd/ChangeLog
bfd/coff-i860.c
bfd/tekhex.c
binutils/ChangeLog
binutils/coffdump.c
binutils/coffgrok.c
binutils/coffgrok.h
binutils/srconv.c