i965/vec4: Always split uniforms in array_access_to_pull_constants
authorJason Ekstrand <jason.ekstrand@intel.com>
Tue, 19 Apr 2016 01:57:07 +0000 (18:57 -0700)
committerJason Ekstrand <jason.ekstrand@intel.com>
Wed, 20 Apr 2016 16:15:01 +0000 (09:15 -0700)
commit87a4fb516eeebd6be0441db5aeffc705f16bef86
treefa18d176a5b7d1641eae2b0972d62cf016642e66
parentb3f43822c72301c904fd2824ae3edcd20ea93a29
i965/vec4: Always split uniforms in array_access_to_pull_constants

Normally, we split uniforms at the end but in Vulkan, we bail because we
don't want pull constants.  However, we still need them split because
pack_uniforms relies on it.

I really don't like this patch not because it doesn't work (it does) but
because now that we're using MOV_INDIRECT, uniform numbers and sizes don't
really matter anymore.  In the FS backend, uniform splitting and packing is
handled all at once (actual re-assignment of locations happens later) and
we really should do it that way in vec4 eventually as well.

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94998
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95001
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp