Refactor cmake: auto-download and default-on dependencies (#6355)
authorGereon Kremer <gkremer@stanford.edu>
Fri, 16 Apr 2021 11:06:40 +0000 (13:06 +0200)
committerGitHub <noreply@github.com>
Fri, 16 Apr 2021 11:06:40 +0000 (11:06 +0000)
commit87bc1447d59e36410feab768ea2bbb577e58fb7b
treef4b53d672c94eb538e07193a1fcd7134767773d6
parent7cae3947227391313d93fa1e2ef7bfb4e9e3986d
Refactor cmake: auto-download and default-on dependencies (#6355)

This PR changes a few things in how dependencies are handled during configuration:

- --x-dir are removed for most dependencies, use the generic --dep-path instead
- the cmake ENABLE_AUTO_DOWNLOAD determines whether we attempt to download missing dependencies ourselves
- external projects check this option and send an error if it is OFF
- some optional dependencies are enabled by default (CaDiCaL, Poly, SymFPU)

This will essentially fail every call to ./configure.sh until the user specifies --auto-download.
13 files changed:
.github/workflows/ci.yml
CMakeLists.txt
cmake/FindANTLR3.cmake
cmake/FindCLN.cmake
cmake/FindCaDiCaL.cmake
cmake/FindCryptoMiniSat.cmake
cmake/FindGMP.cmake
cmake/FindGTest.cmake
cmake/FindKissat.cmake
cmake/FindPoly.cmake
cmake/FindSymFPU.cmake
cmake/deps-helper.cmake
configure.sh