RISC-V: PR28789, Reject R_RISCV_PCREL relocations with ABS symbol in PIC/PIE.
authorPalmer Dabbelt <palmer@rivosinc.com>
Sat, 25 Mar 2023 00:41:13 +0000 (08:41 +0800)
committerNelson Chu <nelson@rivosinc.com>
Wed, 29 Mar 2023 23:40:17 +0000 (07:40 +0800)
commit890744e8585ad75e4adf7b4c447301540479a885
tree215b7b347d5329e2a47c5aaf6f4f3dc337d6b444
parentb679fb488a8c35e573d50f118a09f72c1f6289de
RISC-V: PR28789, Reject R_RISCV_PCREL relocations with ABS symbol in PIC/PIE.

The non-preemptible SHN_ABS symbol with a pc-relative relocation should be
disallowed when generating shared object (pic and pie).  Generally, the
following cases, which refer to pr25749, will cause a symbol be
non-preemptible,

* -pie, or -shared with -symbolic
* STV_HIDDEN, STV_INTERNAL, STV_PROTECTED
* Have dynamic symbol table, but without the symbol
* VER_NDX_LOCAL

However, PCREL_HI20/LO12 relocs are always bind locally when generating
shared object, so not only the non-preemptible absolute symbol need to
be disallowed, all absolute symbol references need but except that they
are defined in linker script.  If we also disallow the absolute symbol
in linker script, then the glibc-linux toolchain build failed, so regard
them as pc-relative symbols, just like what x86 did.

Maybe we should add this check for all pc-relative relocations, rather
than just handle in R_RISCV_PCREL relocs.  Ideally, since the value of
SHN_ABS symbol is a constant, only S - A relocations should be allowed
in the shared object, so only BFD_RELOC_8/16/32/64 are allowed, which
means R_RISCV_32/R_RISCV_64.

bfd/
    PR 28789
    * elfnn-riscv.c (riscv_elf_check_relocs): The absolute symbol cannot be
    referneced with pc-relative relocation when generating shared object.
ld/
    PR 28789
    * ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp: Updated.
    * ld/testsuite/ld-riscv-elf/pcrel-reloc*: New testcases.
bfd/elfnn-riscv.c
ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp
ld/testsuite/ld-riscv-elf/pcrel-reloc-abs-nopie.d [new file with mode: 0644]
ld/testsuite/ld-riscv-elf/pcrel-reloc-abs-pie.d [new file with mode: 0644]
ld/testsuite/ld-riscv-elf/pcrel-reloc-abs.s [new file with mode: 0644]
ld/testsuite/ld-riscv-elf/pcrel-reloc-rel-nopie.d [new file with mode: 0644]
ld/testsuite/ld-riscv-elf/pcrel-reloc-rel-pie.d [new file with mode: 0644]
ld/testsuite/ld-riscv-elf/pcrel-reloc-rel.s [new file with mode: 0644]
ld/testsuite/ld-riscv-elf/pcrel-reloc.s [new file with mode: 0644]