Remove a VEC from type.c
authorTom Tromey <tom@tromey.com>
Tue, 29 May 2018 06:29:23 +0000 (00:29 -0600)
committerTom Tromey <tom@tromey.com>
Tue, 29 May 2018 17:44:12 +0000 (11:44 -0600)
commit894882e344735ace5231f179484086f7697d27cc
tree87bc3c9797d3c9f3eb47053e85cc6a63b298ca62
parent10b2ded43caa3298cded1df8b620caaaee3f9209
Remove a VEC from type.c

This removes a VEC from type.c, by using std::vector.

While doing this I also took the opportunity to change
types_deeply_equal to return bool.  This caught some weird code in
typy_richcompare, now fixed.

And, since I was changing types_deeply_equal, it seemed like a good
idea to also change types_equal, so this patch includes that as well.

Tested by the buildbot.

ChangeLog
2018-05-29  Tom Tromey  <tom@tromey.com>

* python/py-type.c (typy_richcompare): Update.
* guile/scm-type.c (tyscm_equal_p_type_smob): Update.
* gdbtypes.h (types_deeply_equal): Return bool.
(types_equal): Likewise.
* gdbtypes.c (type_equality_entry_d): Remove typedef.  Don't
declare VEC.
(check_types_equal): Change worklist to std::vector.  Return
bool.
(struct type_equality_entry): Add constructor.
(compare_maybe_null_strings): Return bool.
(check_types_worklist): Return bool.  Change worklist to
std::vector.
(types_deeply_equal): Use std::vector.
(types_equal): Return bool.
(compare_maybe_null_strings): Simplify.
gdb/ChangeLog
gdb/gdbtypes.c
gdb/gdbtypes.h
gdb/guile/scm-type.c
gdb/python/py-type.c