bfd_get_symbol_leading_char vs. ""
authorAlan Modra <amodra@gmail.com>
Tue, 22 Aug 2023 11:43:41 +0000 (21:13 +0930)
committerAlan Modra <amodra@gmail.com>
Wed, 23 Aug 2023 00:37:45 +0000 (10:07 +0930)
commit8c8145a43ee4815b8851f8da7091c04f551dff6e
treeba368cb19bfdeb00b9a51e22dd01edafc0ca5859
parente2ce77cd639c86ce89b10ee70e73bd09670e0111
bfd_get_symbol_leading_char vs. ""

Some places matching the first char of a string against
bfd_get_symbol_leading_char, which may be zero, didn't check for the
string being "".  This patch adds the check to stop accesses past the
end of the string and potential buffer overruns.
The dlltool one was found by oss-fuzz quite a while ago.

bfd/
* cofflink.c (_bfd_coff_link_input_bfd): Ensure a zero
bfd_get_symbol_leading_char doesn't lead to accessing past the
zero string terminator.
* linker.c (bfd_wrapped_link_hash_lookup): Likewise.
(unwrap_hash_lookup): Likewise.
binutils/
* dlltool.c (scan_filtered_symbols): Ensure a zero
bfd_get_symbol_leading_char doesn't lead to accessing past the
zero string terminator.
bfd/cofflink.c
bfd/linker.c
binutils/dlltool.c