(new theory) Update TheoryArrays to the new standard (#5000)
authorAndrew Reynolds <andrew.j.reynolds@gmail.com>
Wed, 2 Sep 2020 15:56:53 +0000 (10:56 -0500)
committerGitHub <noreply@github.com>
Wed, 2 Sep 2020 15:56:53 +0000 (10:56 -0500)
commit8d10d1053a0616d8e791219f651b22c10f9039bf
tree4d145eebdc3687a2200a6334f84c65c800a99577
parent1e93736643667d7b8e4ff9fa5f86596ce1ec31d3
(new theory) Update TheoryArrays to the new standard (#5000)

This includes using the standard d_conflict flag in TheoryState and splitting its check into 3 callbacks.

It also deletes some unused code and eliminates an assertion (line 791 of theory_arrays.cpp) which doesn't hold in a central architecture.

Further work on standardization for arrays will add an InferenceManager to guard its uses of asserting facts to equality engine (both for proofs and configurable theory combination).

FYI @barrettcw
src/CMakeLists.txt
src/theory/arrays/static_fact_manager.cpp [deleted file]
src/theory/arrays/static_fact_manager.h [deleted file]
src/theory/arrays/theory_arrays.cpp
src/theory/arrays/theory_arrays.h