cp-gimplify.c (cp_gimplify_expr): Use get_initialized_tmp_var.
authorJason Merrill <jason@redhat.com>
Thu, 17 Oct 2019 19:09:53 +0000 (15:09 -0400)
committerJason Merrill <jason@gcc.gnu.org>
Thu, 17 Oct 2019 19:09:53 +0000 (15:09 -0400)
commit8e5993e236a50ffc161dd45d1ef3ab86133e3363
treec5450036b286821b43db98f6d8a071af778b76bf
parentc11cccc0285f02f117a1e80924fb7673b6486ce9
cp-gimplify.c (cp_gimplify_expr): Use get_initialized_tmp_var.

* cp-gimplify.c (cp_gimplify_expr): Use get_initialized_tmp_var.

The comment for get_formal_tmp_var says that it shouldn't be used for
expressions whose value might change between initialization and use, and in
this case we're creating a temporary precisely because the value might
change, so we should use get_initialized_tmp_var instead.

I also noticed that many callers of get_initialized_tmp_var pass NULL for
post_p, so it seems appropriate to make it a default argument.

gcc/
* gimplify.h (get_initialized_tmp_var): Add default argument to
post_p.
* gimplify.c (gimplify_self_mod_expr, gimplify_omp_atomic): Remove
NULL post_p argument.
* targhooks (std_gimplify_va_arg_expr): Likewise.

From-SVN: r277128
gcc/ChangeLog
gcc/cp/ChangeLog
gcc/cp/cp-gimplify.c
gcc/gimplify.c
gcc/gimplify.h
gcc/targhooks.c