gdb: cast return value of std::unique_ptr::release to void
authorSimon Marchi <simon.marchi@efficios.com>
Mon, 13 Feb 2023 19:55:13 +0000 (14:55 -0500)
committerSimon Marchi <simon.marchi@efficios.com>
Tue, 14 Feb 2023 19:25:48 +0000 (14:25 -0500)
commit8eaecfb37c8ece7396303dd3122def526a223d70
treebe3cba32a5b2cc9105541bf7d72b9e918ea70704
parent92a2cc556c702154fcbc69f7def2a023185f25dd
gdb: cast return value of std::unique_ptr::release to void

My editor shows warnings like:

     value.c:2784: warning: The value returned by this function should be used
     value.c:2784: note: cast the expression to void to silence this warning [bugprone-unused-return-value]

These warnings come from clangd, so ultimately from one of the clang
static analyzers (probably clang-tidy).

Silence these warnings by casting to void.  Add a comment to explain
why this unusual thing is done.

Change-Id: I58323959c0baf9f1b20a8d596e4c58dc77c6809a
Approved-By: Tom Tromey <tom@tromey.com>
gdb/value.c