Add NodeManagerScopes to fix use-after-free issues (#4768)
authorAndres Noetzli <andres.noetzli@gmail.com>
Fri, 17 Jul 2020 22:25:54 +0000 (15:25 -0700)
committerGitHub <noreply@github.com>
Fri, 17 Jul 2020 22:25:54 +0000 (15:25 -0700)
commit8f085eb6a087242ab8c775ec4fe41ab9a194cec2
treeb21935259add8fdbfca57bf4fdd1a76ea96985d9
parentf99889b0c1260fccf28daac995e58312912bae9f
Add NodeManagerScopes to fix use-after-free issues (#4768)

This commit fixes our current ASan issues. Some methods in `NodeManager`
were not creating a `NodeManagerScope` for `this` but were indirectly
calling methods that get the `NodeManager` from the current scope, so we
ended up calling methods on a `NodeManager` that had already been
destroyed.
src/expr/node_manager.cpp
src/expr/node_manager.h