section-select: Fix performance problem (PR30367)
authorMichael Matz <matz@suse.de>
Tue, 18 Apr 2023 14:16:01 +0000 (16:16 +0200)
committerMichael Matz <matz@suse.de>
Tue, 25 Apr 2023 12:55:22 +0000 (14:55 +0200)
commit8f5cd47bee6c07c33aeda758d8d8db5f81ae03e7
tree8601798f81fe7f2f561a600d6174d00353952a92
parent7a29ee290307087e1749ce610207e93a15d0b78d
section-select: Fix performance problem (PR30367)

when using many wild-statements with non-wildcard filenames we
were running into quadraticness via repeatedly using lookup_name
on a long list of loaded files.  I've originally retained using
lookup_name because that preserved existing behaviour most obviously.
In particular in matching wild-statements when using a non-wildcard
filename it matches against local_sym_name, not the filename member.
If the wildspec would have an archive-spec or a wildcard it would use
the filename member, though.  Also it would load the named file
(and ignore it, as being not equal to the currently considered
input-statement).

Rewrite this to not use lookup_name but retain the comparison
against local_sym_name with a comment to that effect.

PR 30367
* ldlang.c (walk_wild_section_match): Don't use lookup_name
but directly compare spec and local_sym_name.
ld/ldlang.c