[gdb/tui] Fix Wmaybe-uninitialized warning in tui-winsource.c
authorTom de Vries <tdevries@suse.de>
Thu, 23 Jul 2020 11:45:46 +0000 (13:45 +0200)
committerTom de Vries <tdevries@suse.de>
Thu, 23 Jul 2020 11:45:46 +0000 (13:45 +0200)
commit90fcc46681979a7759d16e738a98c9e666e6e88f
tree68acb6ec444ebc7a8e96afb3ac8e3cea8dfca1a1
parent78344df7b5d7d7fcf6aa7945b8c4b56bcc9388ce
[gdb/tui] Fix Wmaybe-uninitialized warning in tui-winsource.c

When compiling with CFLAGS/CXXFLAGS="-O0 -g -Wall" and using g++ 11.0.0, we
run into:
...
src/gdb/tui/tui-winsource.c: In function \
  'void tui_update_all_breakpoint_info(breakpoint*)':
src/gdb/tui/tui-winsource.c:427:58: warning: '<unknown>' may be used \
  uninitialized [-Wmaybe-uninitialized]
  427 |   for (tui_source_window_base *win : tui_source_windows ())
      |                                                          ^
In file included from src/gdb/tui/tui-winsource.c:38:
src/gdb/tui/tui-winsource.h:236:30: note: by argument 1 of type \
  'const tui_source_windows*' to 'tui_source_window_iterator \
  tui_source_windows::begin() const' declared here
  236 |   tui_source_window_iterator begin () const
      |                              ^~~~~
src/gdb/tui/tui-winsource.c:427:58: note: '<anonymous>' declared here
  427 |   for (tui_source_window_base *win : tui_source_windows ())
      |                                                          ^
...

The warning doesn't make sense for an empty struct, PR gcc/96295 has been
filed about that.

For now, work around the warning by defining a default constructor.

Build on x86_64-linux.

gdb/ChangeLog:

2020-07-23  Tom de Vries  <tdevries@suse.de>

PR tui/26282
* tui/tui-winsource.h (struct tui_source_windows::tui_source_windows):
New default constructor.
gdb/ChangeLog
gdb/tui/tui-winsource.h