utils/check-package: detect the use of ${} in .mk files
authorRicardo Martincoski <ricardo.martincoski@gmail.com>
Mon, 9 Jul 2018 01:56:47 +0000 (22:56 -0300)
committerThomas Petazzoni <thomas.petazzoni@bootlin.com>
Thu, 20 Sep 2018 22:05:55 +0000 (00:05 +0200)
commit910ee6f7bd23da264fa47a820506ca64e9e7b738
treea80edd2c659f6e53a79de3827b9aab60bb5f32e8
parente9963cd2b51f2f5d64c576ad2f2188a644627be3
utils/check-package: detect the use of ${} in .mk files

And warn to use $() instead.
For examples see [1] and [2].

In the regexp, search for ${VARIABLE} but:
 - ignore comments;
 - ignore variables to be expanded by the shell "$${}".

[1] http://lists.busybox.net/pipermail/buildroot/2018-July/225211.html
[2] https://github.com/buildroot/buildroot/commit/36305380db1312442623128689fe5067d9058381

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Cc: Arnout Vandecappelle <arnout@mind.be>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Yann E. MORIN <yann.morin.1998@free.fr>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
utils/checkpackagelib/lib_mk.py