Fix thinko on dtrace-probe.c:dtrace_process_dof_probe
authorSergio Durigan Junior <sergiodj@redhat.com>
Fri, 8 Dec 2017 20:33:55 +0000 (15:33 -0500)
committerSergio Durigan Junior <sergiodj@redhat.com>
Fri, 8 Dec 2017 20:33:55 +0000 (15:33 -0500)
commit92469284a650232768523564f2c715c4ebb57906
tree3393e764d2e67ab28c03c95f1cf4421881f44094
parentf17d9474776e50ae47aa71c52211ea6e21adf5d5
Fix thinko on dtrace-probe.c:dtrace_process_dof_probe

While investigating PR gdb/22557 ("Regression:
gdb.base/dtrace-probe.exp"), I noticed that the code is wrongly
declaring a new "expression_up" variable inside the TRY block in
"dtrace_process_dof_probe".  This causes the outter "expr" variable to
be empty, which may have an impact later when evaluating the
expression.

This commit fixes that.  Unfortunately the script used to test DTrace
probes (gdb/testsuite/lib/pdtrace.in) is not very reliable so I cannot
say whether this commit fixes the PR mentioned above.  Nonetheless,
it's an obvious fix and should go in.

gdb/ChangeLog:
2017-12-08  Sergio Durigan Junior  <sergiodj@redhat.com>

* dtrace-probe.c (dtrace_process_dof_probe): Do not declare a new
"expression_up" inside the TRY block.
gdb/ChangeLog
gdb/dtrace-probe.c