Simplify compile_module cleanup
authorTom Tromey <tom@tromey.com>
Wed, 23 Sep 2020 15:32:54 +0000 (09:32 -0600)
committerTom Tromey <tom@tromey.com>
Wed, 23 Sep 2020 15:32:56 +0000 (09:32 -0600)
commit92677124d90f0690ec5ffb6ee0a7b5097f95b135
tree857576b16b81d4d26c44f3c66ef4192148b64cdb
parente616f60a6bc233acdb9ad1c37833a976f21aecec
Simplify compile_module cleanup

This simplifies compile_module cleanup by removing the need to
explicitly free anything.  struct setup_sections_data is also cleaned
up a bit.

gdb/ChangeLog
2020-09-23  Tom Tromey  <tom@tromey.com>

* compile/compile-object-run.c (do_module_cleanup)
<~do_module_cleanup> :Remove.
(do_module_cleanup): Update.
* compile/compile-object-load.h (struct munmap_list): Add move
assignment operator.
<source_file>: Now a std::string.
<munmap_list>: Rename.  No longer a pointer.
* compile/compile-object-load.c (struct setup_sections_data): Add
constructor.
<setup_one_section>: Declare.
<munmap_list>: Move earlier.
<m_bfd>: New member.
<m_last_size, m_last_section_first, m_last_prot,
m_last_max_alignment>: Rename, add initializers where needed.
(setup_sections_data::setup_one_section): Rename from
setup_sections.  Update.
(compile_object_load): Update.  Don't use bfd_map_over_sections.
gdb/ChangeLog
gdb/compile/compile-object-load.c
gdb/compile/compile-object-load.h
gdb/compile/compile-object-run.c