gdb: check for groups with duplicate names in reggroups:add
authorSimon Marchi <simon.marchi@efficios.com>
Tue, 18 Oct 2022 14:17:33 +0000 (10:17 -0400)
committerSimon Marchi <simon.marchi@polymtl.ca>
Wed, 19 Oct 2022 02:11:49 +0000 (22:11 -0400)
commit9454c9ce88b25646d279feed329c9cdba69b4905
treebb310d509a7f5c4e1ece0cb3016dded9a2451baa
parentfd320c4c29c9a1915d24a68a167a5fd6d2c27e60
gdb: check for groups with duplicate names in reggroups:add

In the downstream ROCm GDB port, we would create multiple register
groups with duplicate names.  While it did not really hurt, it certainly
wasn't the intent.  And I don't think it ever makes sense to do so.

To catch these, change the assert in reggroups::add to check for
duplicate names.  It's no longer necessary to check for duplicate
reggroup pointers, because adding the same group twice would be caught
by the duplicate name check.

Change-Id: Id216a58acf91f1b314d3cba2d02de73656f8851d
Approved-By: Tom Tromey <tom@tromey.com>
gdb/reggroups.c