Change gcc_target_options to return std::string
authorTom Tromey <tromey@adacore.com>
Tue, 15 Oct 2019 16:57:40 +0000 (10:57 -0600)
committerTom Tromey <tromey@adacore.com>
Tue, 15 Oct 2019 17:03:57 +0000 (11:03 -0600)
commit953cff563058831ab0bf863c7655d23b5e6a5989
treeb7c925518139ea7492e4ffdee4ef3ae6f11667ad
parent81e6b8eb208c427028d919afb2b5cabbc355fc88
Change gcc_target_options to return std::string

This patch was inspired by a recent review that recommended using
std::string in a new implementation of the gcc_target_options gdbarch
function.  It changes this function to return std::string rather than
an ordinary xmalloc'd string.

I believe this caught a latent memory leak in compile.c:get_args.

Tested on x86-64 Fedora 29.

gdb/ChangeLog
2019-10-15  Tom Tromey  <tromey@adacore.com>

* gdbarch.h, gdbarch.c: Rebuild.
* gdbarch.sh (gcc_target_options): Change return type to
std::string.
* compile/compile.c (get_args): Update.
* nios2-tdep.c (nios2_gcc_target_options): Return std::string.
* arm-linux-tdep.c (arm_linux_gcc_target_options): Return
std::string.
* aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
std::string.
* arch-utils.c (default_gcc_target_options): Return std::string.
* arch-utils.h (default_gcc_target_options): Return std::string.
* s390-tdep.c (s390_gcc_target_options): Return std::string.

Change-Id: I51f61703426a323089e646da8f22320a2cafbc1f
gdb/ChangeLog
gdb/aarch64-linux-tdep.c
gdb/arch-utils.c
gdb/arch-utils.h
gdb/arm-linux-tdep.c
gdb/compile/compile.c
gdb/gdbarch.c
gdb/gdbarch.h
gdb/gdbarch.sh
gdb/nios2-tdep.c
gdb/s390-tdep.c