Move add_location(sal) to base_breakpoint
authorPedro Alves <pedro@palves.net>
Thu, 12 May 2022 17:58:38 +0000 (18:58 +0100)
committerPedro Alves <pedro@palves.net>
Fri, 20 May 2022 19:41:01 +0000 (20:41 +0100)
commit960bc2bd1402bb5e8312e731d6a7f6fe2b6a9863
treeaff30b1e20a126c1acb744b6989de77ed62947b5
parent92bb0228c8293ec78c0efcd556b1f115b6e1b3f4
Move add_location(sal) to base_breakpoint

After the previous patches, only base_breakpoint subclasses use
add_location(sal), so we can move it to base_breakpoint (a.k.a. base
class for code breakpoints).

This requires a few casts here and there, but always at spots where
you can see from context what the breakpoint's type actually is.

I inlined new_single_step_breakpoint into its only caller exactly for
this reason.

I did try to propagate more use of base_breakpoint to avoid casts, but
that turned out unwieldy for this patch.

Change-Id: I49d959322b0fdce5a88a216bb44730fc5dd7c6f8
gdb/breakpoint.c
gdb/breakpoint.h
gdb/elfread.c
gdb/minsyms.c
gdb/symtab.h