Small clean up of use_displaced_stepping
authorSimon Marchi <simon.marchi@polymtl.ca>
Mon, 2 Mar 2020 20:47:04 +0000 (15:47 -0500)
committerSimon Marchi <simon.marchi@efficios.com>
Mon, 2 Mar 2020 20:57:15 +0000 (15:57 -0500)
commit9822cb57f7570a3b2c8fd95ec2f7b9f9890e30a4
tree8e0ab81a4563552dee890eadbed32154de94ee0b
parent63e163f24fe80fe1509527e6ccfcfb9622f5e99e
Small clean up of use_displaced_stepping

This function returns the result of a quite big condition.  I think it
would be more readeable if it was broken up in smaller pieces and
commented.  This is what this patch does.

I also introduced gdbarch_supports_displaced_stepping, since it shows
the intent better than checking for gdbarch_displaced_step_copy_insn_p.
I also used that new function in displaced_step_prepare_throw.

I also updated the comment on top of can_use_displaced_stepping, which
seemed a bit outdated with respect to non-stop.  The comment likely
dates from before it was possible to have targets that always operate
non-stop under the hood, even when the user-visible mode is all-stop.

No functional changes intended.

gdb/ChangeLog:

* infrun.c (gdbarch_supports_displaced_stepping): New.
(use_displaced_stepping): Break up conditions in smaller pieces.
Use gdbarch_supports_displaced_stepping.
(displaced_step_prepare_throw): Use
gdbarch_supports_displaced_stepping.
gdb/ChangeLog
gdb/infrun.c