Fix PR82488 - signed integer overflow in expr.c
authorMarkus Trippelsdorf <markus@trippelsdorf.de>
Mon, 27 Nov 2017 05:20:43 +0000 (05:20 +0000)
committerMarkus Trippelsdorf <trippels@gcc.gnu.org>
Mon, 27 Nov 2017 05:20:43 +0000 (05:20 +0000)
commit99282f81a6bcb5873c2a3c4755f625b5a44a915d
treec003d29fccbed0d3197d3f058e86ffa7b1f173ab
parent62e8530cd54126ab5be8a7815df47dab5c8e6905
Fix PR82488 - signed integer overflow in expr.c

bootstrap-ubsan shows:
 gcc/expr.c:4103:17: runtime error: signed integer overflow: 0 - -9223372036854775808 cannot be represented in type 'long int'

Fix by handling the saw_unknown case earlier.

PR rtl-optimization/82488
* expr.c (fixup_args_size_notes): Avoid signed integer overflow.

diff --git a/gcc/expr.c b/gcc/expr.c
index ee07de5aaa44..e9d8555c9452 100644
--- a/gcc/expr.c
+++ b/gcc/expr.c
@@ -4100,10 +4100,13 @@ fixup_args_size_notes (rtx_insn *prev, rtx_insn *last, int end_args_size)
       if (STACK_GROWS_DOWNWARD)
  this_delta = -(unsigned HOST_WIDE_INT) this_delta;

-      args_size -= this_delta;
+      if (saw_unknown)
+ args_size = INT_MIN;
+      else
+ args_size -= this_delta;
     }

-  return saw_unknown ? INT_MIN : args_size;
+  return args_size;
 }

 #ifdef PUSH_ROUNDING
--
Markus

From-SVN: r255159
gcc/ChangeLog
gcc/expr.c