iris: Don't skip fast depth clears if the color changed
authorJason Ekstrand <jason@jlekstrand.net>
Thu, 5 Mar 2020 23:17:40 +0000 (17:17 -0600)
committerMarge Bot <eric+marge@anholt.net>
Fri, 6 Mar 2020 01:40:02 +0000 (01:40 +0000)
commit9d07d598423e4015bbc7beb7a2fdc4c657d5e0cf
tree6bf229c2cc004c3b0a6ea6a648d90fe3cc8674f3
parent382b902a6db87a2b0409b760c320555d1f4eadca
iris: Don't skip fast depth clears if the color changed

We depend on BLORP to convert the clear color and write it into the
clear color buffer for us.  However, we weren't bothering to call blorp
in the case where the state is ISL_AUX_STATE_CLEAR.  This leads to the
clear color not getting properly updated if we have back-to-back clears
with different clear colors.  Technically, we could go out of our way to
set the clear color directly from iris in this case but this is a case
we're unlikely to see in the wild so let's not bother.  This matches
what we already do for color surfaces.

Cc: mesa-stable@lists.freedesktop.org
Reported-by: Mark Janes <mark.a.janes@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4073>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4073>
src/gallium/drivers/iris/iris_clear.c