cpu, kvm: Fix deadlock issue when resuming a drained system
authorAndreas Sandberg <andreas.sandberg@arm.com>
Thu, 20 Jul 2017 16:32:10 +0000 (16:32 +0000)
committerAndreas Sandberg <andreas.sandberg@arm.com>
Tue, 1 Aug 2017 16:20:24 +0000 (16:20 +0000)
commit9d6d3e5f7dd50e882a503ee4bb2ac7d9b8d21e30
tree420084c370fc482015c2b00af84b0fe11be88b3a
parentc464f67955a131843cf232c5cd5430206e2494ab
cpu, kvm: Fix deadlock issue when resuming a drained system

The KVM CPU sometimes needs to access devices when drain() is
called. This typically happens on ARM when synchronizing devices that
use the system register interface. When called from drain(), the event
queue isn't locked since drain is called from the outside when the
simulator isn't servicing any events. In such cases, performing a
migration to the device's queue will unlock a mutex that isn't
locked. This typically results in a deadlock when resuming the system
since the lock will be in an undefined state.

Change-Id: Ibdcc2e034e916a929124f297e72aae306cf66728
Signed-off-by: Andreas Sandberg <andreas.sandberg@arm.com>
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Reviewed-by: Curtis Dunham <curtis.dunham@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/4286
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
src/cpu/kvm/base.cc