MIPS/GAS: Use non-zero frag offset directly in PIC branch relaxation
authorMaciej W. Rozycki <macro@imgtec.com>
Fri, 30 Jun 2017 23:42:19 +0000 (00:42 +0100)
committerMaciej W. Rozycki <macro@imgtec.com>
Fri, 30 Jun 2017 23:42:19 +0000 (00:42 +0100)
commit9f00292e69635d48623372c7a3e390dc5d159a8f
treed625f865ccb7101eea8a9e3b46f4deb0c4c55d93
parent32f76c677333510350f21a40db062a8d17995c53
MIPS/GAS: Use non-zero frag offset directly in PIC branch relaxation

Use frag symbols with a non-zero offset directly in `fix_new_exp' calls
made in PIC branch relaxation.  There is no need here to make a helper
symbol to hold the result of a `symbol+offset' calculation requested as
only branches to local symbols are relaxed and in this case the LO16
part of the PIC address load sequence will have the offset accounted for
in calculation against the local GOT entry retrieved as the GOT16 high
part.  Consequently actual code produed is identical whether a helper
symbol is used or the original `symbol+offset' expression used directly.
Verify that this is indeed the case with GAS and LD tests.

gas/
* config/tc-mips.c (md_convert_frag): Don't make a helper
expression symbol for `fix_new_exp' called with a non-zero
offset.
* testsuite/gas/mips/relax-offset.d: New test.
* testsuite/gas/mips/mips1@relax-offset.d: New test.
* testsuite/gas/mips/r3000@relax-offset.d: New test.
* testsuite/gas/mips/r3900@relax-offset.d: New test.
* testsuite/gas/mips/micromips@relax-offset.d: New test.
* testsuite/gas/mips/relax-offset.l: New stderr output.
* testsuite/gas/mips/relax-offset.s: New test source.
* testsuite/gas/mips/mips.exp: Run the new tests.

ld/
* testsuite/ld-mips-elf/relax-offset.dd: New test.
* testsuite/ld-mips-elf/relax-offset.gd: New test.
* testsuite/ld-mips-elf/relax-offset-umips.dd: New test.
* testsuite/ld-mips-elf/relax-offset-umips.gd: New test.
* testsuite/ld-mips-elf/relax-offset.ld: New test linker script.
* testsuite/ld-mips-elf/mips-elf.exp: Run the new tests.
(prune_warnings): New temporary procedure.
17 files changed:
gas/ChangeLog
gas/config/tc-mips.c
gas/testsuite/gas/mips/micromips@relax-offset.d [new file with mode: 0644]
gas/testsuite/gas/mips/mips.exp
gas/testsuite/gas/mips/mips1@relax-offset.d [new file with mode: 0644]
gas/testsuite/gas/mips/r3000@relax-offset.d [new file with mode: 0644]
gas/testsuite/gas/mips/r3900@relax-offset.d [new file with mode: 0644]
gas/testsuite/gas/mips/relax-offset.d [new file with mode: 0644]
gas/testsuite/gas/mips/relax-offset.l [new file with mode: 0644]
gas/testsuite/gas/mips/relax-offset.s [new file with mode: 0644]
ld/ChangeLog
ld/testsuite/ld-mips-elf/mips-elf.exp
ld/testsuite/ld-mips-elf/relax-offset-umips.dd [new file with mode: 0644]
ld/testsuite/ld-mips-elf/relax-offset-umips.gd [new file with mode: 0644]
ld/testsuite/ld-mips-elf/relax-offset.dd [new file with mode: 0644]
ld/testsuite/ld-mips-elf/relax-offset.gd [new file with mode: 0644]
ld/testsuite/ld-mips-elf/relax-offset.ld [new file with mode: 0644]