gallium/u_queue: guard fence->signalled checks with fence->mutex
authorNicolai Hähnle <nicolai.haehnle@amd.com>
Sat, 9 Jul 2016 17:40:51 +0000 (19:40 +0200)
committerNicolai Hähnle <nicolai.haehnle@amd.com>
Mon, 11 Jul 2016 09:03:59 +0000 (11:03 +0200)
commita0a616720ade8b35171fc8755803ec123d0d98fc
tree0d7b5a72fa2da511cab6192969539b10f8a9ad66
parent5c17fb2cd67b75b42e75c501cb6ae85fbb28bbc8
gallium/u_queue: guard fence->signalled checks with fence->mutex

I have seen a hang during application shutdown that could be explained by the
following race condition which this patch fixes:

1. Worker thread enters util_queue_fence_signal, sets fence->signalled = true.
2. Main thread calls util_queue_job_wait, which returns immediately.
3. Main thread deletes the job and fence structures, leaving garbage behind.
4. Worker thread calls pipe_condvar_broadcast, which gets stuck forever because
   it is accessing garbage.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Edward O'Callaghan <funfunctor@folklore1984.net>
src/gallium/auxiliary/util/u_queue.c