Use std::vector in uploaded_tp
authorSimon Marchi <simon.marchi@polymtl.ca>
Fri, 30 Mar 2018 21:18:54 +0000 (17:18 -0400)
committerSimon Marchi <simon.marchi@polymtl.ca>
Fri, 30 Mar 2018 21:18:54 +0000 (17:18 -0400)
commita18ba4e4c9d64eeb2ea65e5315fbd8b4261a1756
tree0305bf8d7650858d6095d28a0dd9c2d55e186562
parenta7961323e2fce4f831e117cc43e20e5144192240
Use std::vector in uploaded_tp

This patch changes the VEC(char_ptr) fields in uploaded_tp to use
std::vector<char *>.  At first, I wanted to creep in more changes, like
using std::string, but it was making the patch too big and less focused,
so I decided to keep it to just that.

It also looks like the strings in those vectors are never free'd.  If
so, we can fix that in another patch.

gdb/ChangeLog:

* tracepoint.h (struct uploaded_tp): Initialize fields.
<actions, step_actions, cmd_strings>: Change type to
std::vector<char *>.
* tracepoint.c (get_uploaded_tp): Allocate with new.
(free_uploaded_tps): Free with delete.
(parse_tracepoint_definition): Adjust to std::vector change.
* breakpoint.c (read_uploaded_action): Likewise.
(create_tracepoint_from_upload): Likewise.
* ctf.c (ctf_write_uploaded_tp): Likewise.
(SET_ARRAY_FIELD): Likewise.
* tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
gdb/ChangeLog
gdb/breakpoint.c
gdb/ctf.c
gdb/tracefile-tfile.c
gdb/tracepoint.c
gdb/tracepoint.h