PR gdb/30214: Prefer local include paths to system include paths
authorJohn Baldwin <jhb@FreeBSD.org>
Fri, 10 Mar 2023 20:01:40 +0000 (12:01 -0800)
committerJohn Baldwin <jhb@FreeBSD.org>
Fri, 10 Mar 2023 20:01:43 +0000 (12:01 -0800)
commita2fbb6903889c8fe32f4f3b890ef4b8c565d6b84
tree63204df8e657a5e4676c47623725a5b223f4d35a
parent2cef48423031d23d319692ceced5ad0110625f69
PR gdb/30214: Prefer local include paths to system include paths

Some systems may install binutils headers into a system location
(e.g. /usr/local/include on FreeBSD) which may also include headers
for other external packages used by GDB such as zlib or zstd.  If a
system include path such as /usr/local/include is added before local
include paths to directories within a clone or release tarball, then
headers from the external binutils package are used which can result
in build failures if the external binutils package is out of sync with
the version of GDB being built.

To fix, sort the include paths in INTERNAL_CFLAGS_BASE to add CFLAGS
for "local" componenets before external components.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30214
Reviewed-By: Tom Tromey <tom@tromey.com>
gdb/Makefile.in