gdbserver: decouple x86 watchpoint / hw breakpoint routines from Z packet numbers.
authorPedro Alves <palves@redhat.com>
Tue, 22 Apr 2014 18:47:04 +0000 (19:47 +0100)
committerPedro Alves <palves@redhat.com>
Wed, 23 Apr 2014 17:33:52 +0000 (18:33 +0100)
commita4165e94f452b3137a1071a5034853a93a9de1a2
tree6df836db855c5b2464ef3a4c757d6be41252a135
parentb8acf843690988fa96123b3c54bc3850d874eb35
gdbserver: decouple x86 watchpoint / hw breakpoint routines from Z packet numbers.

My main motivation here is moving in the direction of decoupling
insert_point/remove_point from packet numbers, though this bit alone
should make it a little bit easier to merge gdb/gdbserver/i386-low.c
and gdb/i386-nat.c (which are largely the same).

Tested on x86_64 Fedora 17, and cross built for i686-mingw32 too.

gdb/gdbserver/
2014-04-23  Pedro Alves  <palves@redhat.com>

* i386-low.c: Don't include break-common.h here.
(i386_low_insert_watchpoint, i386_low_remove_watchpoint): Change
prototype to take target_hw_bp_type as argument instead of a Z
packet char.
* i386-low.h: Include break-common.h here.
(Z_packet_to_hw_type): Declare.
(i386_low_insert_watchpoint, i386_low_remove_watchpoint): Change
prototypes.
* linux-x86-low.c (x86_insert_point): Convert the packet number to
a target_hw_bp_type before calling i386_low_insert_watchpoint.
(x86_remove_point): Convert the packet number to a
target_hw_bp_type before calling i386_low_remove_watchpoint.
* win32-i386-low.c (i386_insert_point): Convert the packet number
to a target_hw_bp_type before calling i386_low_insert_watchpoint.
(i386_remove_point): Convert the packet number to a
target_hw_bp_type before calling i386_low_remove_watchpoint.
gdb/gdbserver/ChangeLog
gdb/gdbserver/i386-low.c
gdb/gdbserver/i386-low.h
gdb/gdbserver/linux-x86-low.c
gdb/gdbserver/win32-i386-low.c