linemap_line_start: protect against location_t overflow (PR lto/88147)
authorDavid Malcolm <dmalcolm@gcc.gnu.org>
Tue, 12 Feb 2019 01:09:31 +0000 (01:09 +0000)
committerDavid Malcolm <dmalcolm@gcc.gnu.org>
Tue, 12 Feb 2019 01:09:31 +0000 (01:09 +0000)
commita4553534dfcccf992d30307a8bdbb5405ecd01f7
treef67e59ffd6fb5cf560579cb0ca4c399c581cda40
parentf11bb3106f4232ea2c9a2bc754a7d929879ea746
linemap_line_start: protect against location_t overflow (PR lto/88147)

PR lto/88147 reports an assertion failure due to a bogus location_t value
when adding a line to a pre-existing line map, when there's a large
difference between the two line numbers.

For some "large differences", this leads to a location_t value that exceeds
LINE_MAP_MAX_LOCATION, in which case linemap_line_start returns 0.  This
isn't ideal, but at least should lead to safe degradation of location
information.

However, if the difference is very large, it's possible for the line
number offset (relative to the start of the map) to be sufficiently large
that overflow occurs when left-shifted by the column-bits, and hence
the check against the LINE_MAP_MAX_LOCATION limit fails, leading to
a seemingly-valid location_t value, but encoding the wrong location.  This
triggers the assertion failure:
  linemap_assert (SOURCE_LINE (map, r) == to_line);

The fix (thanks to Martin) is to check for overflow when determining
whether to reuse an existing map, and to not reuse it if it would occur.

gcc/ChangeLog: David Malcolm  <dmalcolm@redhat.com>
PR lto/88147
* input.c (selftest::test_line_offset_overflow): New selftest.
(selftest::input_c_tests): Call it.

libcpp/ChangeLog: Martin Liska  <mliska@suse.cz>
PR lto/88147
* line-map.c (linemap_line_start): Don't reuse the existing line
map if the line offset is sufficiently large to cause overflow
when computing location_t values.

From-SVN: r268789
gcc/ChangeLog
gcc/input.c
libcpp/ChangeLog
libcpp/line-map.c