systemc: Remove a redundant injectException for Thread's throw_it.
authorGabe Black <gabeblack@google.com>
Sat, 6 Oct 2018 09:58:02 +0000 (02:58 -0700)
committerGabe Black <gabeblack@google.com>
Tue, 16 Oct 2018 01:02:06 +0000 (01:02 +0000)
commita7d99be947c80de4647d07fd4f73c19cc4050a77
treeb59d98011d72ebc847ce5f73cbf2063f1f7cac13
parent9677f2da711edc3382e754c7dfd62464e904a9e9
systemc: Remove a redundant injectException for Thread's throw_it.

For some reason lost to the sands of time, the throw_it function was
virtual for the Thread class, and that class would call the base
class's throw_it, and then also injectException itself. That would
result in the exception being injected into the thread twice which is
incorrect.

Since it's not clear what the original intention of this code was, the
throw_it function is now no longer virtual, and the one useful aspect
of it, a check if the process is already terminated, was moved into the
base class function.

Change-Id: I7fb14baa7728bd1e9206011870b6ccaa9c4e8c64
Reviewed-on: https://gem5-review.googlesource.com/c/13312
Reviewed-by: Gabe Black <gabeblack@google.com>
Maintainer: Gabe Black <gabeblack@google.com>
src/systemc/core/SConscript
src/systemc/core/process.cc
src/systemc/core/process.hh
src/systemc/core/process_types.cc [deleted file]
src/systemc/core/process_types.hh