base: Remove begin() and end() from CircleBuf.
authorGabe Black <gabe.black@gmail.com>
Tue, 12 Jan 2021 09:02:49 +0000 (01:02 -0800)
committerGabe Black <gabe.black@gmail.com>
Wed, 13 Jan 2021 02:33:58 +0000 (02:33 +0000)
commita7f3c5aad244120afd965490d6dce8d131f01eda
tree80d1dee26f96c29a808591d1753a88da5f37354a
parent43114ad1dd678595a5a67c761f56508d3df3b4b7
base: Remove begin() and end() from CircleBuf.

These functions return iterators which are inconsistent with the usage
model for this type. It should be accessed using the peek, push, and pop
methods and not iterators. If you need a class with iterators which is
oriented around accessing individual elements at a time, the
CircularQueue type is likely a better choice.

Change-Id: I9f37eab12e490b63d870d378a91f601dad353f25
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/38998
Reviewed-by: Daniel Carvalho <odanrc@yahoo.com.br>
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Maintainer: Gabe Black <gabe.black@gmail.com>
Maintainer: Andreas Sandberg <andreas.sandberg@arm.com>
Tested-by: kokoro <noreply+kokoro@google.com>
src/base/circlebuf.hh