[gdb] Improve printing of float formats
authorTom de Vries <tdevries@suse.de>
Wed, 30 Nov 2022 10:37:11 +0000 (11:37 +0100)
committerTom de Vries <tdevries@suse.de>
Wed, 30 Nov 2022 10:37:11 +0000 (11:37 +0100)
commitaaa79cd62b873be672e3163eb267513c97ec4399
tree9c7408044b19cc0d5d112de8361f84eb42df4324
parent6bd454ca033dcb2e178721eb004d0c5f24415c4c
[gdb] Improve printing of float formats

Currently, on x86_64, a little endian target, I get:
...
$ gdb -q -batch -ex "maint print architecture" | grep " = floatformat"
gdbarch_dump: bfloat16_format = floatformat_bfloat16_big
gdbarch_dump: double_format = floatformat_ieee_double_big
gdbarch_dump: float_format = floatformat_ieee_single_big
gdbarch_dump: half_format = floatformat_ieee_half_big
gdbarch_dump: long_double_format = floatformat_i387_ext
...
which suggests big endian.

This is due to this bit of code in pformat:
...
    /* Just print out one of them - this is only for diagnostics.  */
    return format[0]->name;
...

Fix this by using gdbarch_byte_order to pick the appropriate index, such that
we have the more accurate:
...
gdbarch_dump: bfloat16_format = floatformat_bfloat16_little
gdbarch_dump: half_format = floatformat_ieee_half_little
gdbarch_dump: float_format = floatformat_ieee_single_little
gdbarch_dump: double_format = floatformat_ieee_double_little
gdbarch_dump: long_double_format = floatformat_i387_ext
...

Tested on x86_64-linux.
gdb/arch-utils.c
gdb/gdbarch-components.py
gdb/gdbarch.c