c++: ICE with IMPLICIT_CONV_EXPR in array subscript [PR95508]
authorMarek Polacek <polacek@redhat.com>
Wed, 17 Jun 2020 13:19:02 +0000 (09:19 -0400)
committerMarek Polacek <polacek@redhat.com>
Wed, 17 Jun 2020 13:19:02 +0000 (09:19 -0400)
commitae2ebf011fec926e003645c33c07a03619ea216a
tree22786700ccebc85f8db4afd3fe82fefb9be4f656
parent4d2b0866d760f822c137b69f14d1c51fc760ce53
c++: ICE with IMPLICIT_CONV_EXPR in array subscript [PR95508]

Since r10-7096 convert_like, when called in a template, creates an
IMPLICIT_CONV_EXPR when we're converting to/from array type.

In this test, we have e[f], and we're converting f (of type class A) to
int, so convert_like in build_new_op_1 created the IMPLICIT_CONV_EXPR
that got into cp_build_array_ref which calls maybe_constant_value.  My
patch above failed to adjust this spot to call fold_non_dependent_expr
instead, which can handle codes like I_C_E in a template.  Fixed by
using a new function maybe_fold_non_dependent_expr, which, if the expr
can't be evaluated to a constant, returns the original expression.

gcc/cp/ChangeLog:

PR c++/95508
* constexpr.c (maybe_fold_non_dependent_expr): New.
* cp-tree.h (maybe_fold_non_dependent_expr): Declare.
* typeck.c (cp_build_array_ref): Call maybe_fold_non_dependent_expr
instead of maybe_constant_value.

gcc/testsuite/ChangeLog:

PR c++/95508
* g++.dg/template/conv16.C: New test.
gcc/cp/constexpr.c
gcc/cp/cp-tree.h
gcc/cp/typeck.c
gcc/testsuite/g++.dg/template/conv16.C [new file with mode: 0644]